-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15766] Update shared_mutex thirdparty to don't prioritize writers (backport #2976) #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
MiguelBarro
force-pushed
the
mergify/bp/2.6.x/pr-2976
branch
from
November 15, 2022 14:11
8848d7c
to
7cfc365
Compare
@richiprosima Please test this for me 🤯 |
* Add test for multithreaded creation of readers on a single subscriber. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Add DataWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 15766: Refactor of shared_mutex to select writer priority Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766: CMake update to force third party shared mutex if the framework prioritizes writing. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766: Add atomic support for some debian distros Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766: Allow recursiveness on participant endpoint collection mutexes. Now they always allow them. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766: linter pass Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766: Generate the config.h file when the USE_THIRDPARTY_SHARED_MUTEX value is already specified. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766: Mandatory piggyback: avoid polution on free_pools_ collection Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766: Add some missing members to shared_lock thirdparty Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766: linter Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766. shared_mutex testing Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766. fixing gtest backward compatibility issues Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766. Add a new test to check priority is right Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766. Fixing gcc build warnings Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766. Fixing clang build warnings Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766. Make thirdparty versions always available even if none is used as eprosima::shared_mutex. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766. Addressing reviewers comments Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 15766. Fixing sync issue on ProxyPool. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelBarro
force-pushed
the
mergify/bp/2.6.x/pr-2976
branch
from
November 15, 2022 15:18
7cfc365
to
70bac5a
Compare
@richiprosima Please test this for me 🤯 |
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@richiprosima Please test this for me 🤯 |
…pected. Do we need a foreport? Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@richiprosima Please test this for me 🤯 |
MiguelCompany
approved these changes
Nov 30, 2022
@richiprosima Please test this since there was another PR merged in the middle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2976 done by Mergify.
Cherry-pick of 47d85d3 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com