Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16277] Fix communication with asymmetric ignoreParticipantFlags #3105

Merged
merged 5 commits into from
Nov 24, 2022

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 21, 2022

Description

Configuring a participant with ignoreParticipantFlags = FILTER_DIFFERENT_HOST | FILTER_DIFFERENT_PROCESS, and another one with the default configuration ignoreParticipantFlags = FILTER_NONE results in HEARTBEAT and ACKNACK messages sent to the multicast address and port for the builtin endpoints.

This PR fixes that situation by:

  1. Make participants that only want intraprocess communications to not announce locators
  2. Always ignore participants without locators when they are not on the same process.

As a bonus, participants that only want intraprocess communications set multicast TTL to 0 (so their announcements do not leave the host) and avoids creating the SHM transport.

@Mergifyio backport 2.7.x 2.6.x 2.1.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
…e no locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
…ants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 865702b into master Nov 24, 2022
@EduPonz EduPonz deleted the bugfix/16253 branch November 24, 2022 10:47
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 2.7.x 2.6.x 2.1.x

mergify bot pushed a commit that referenced this pull request Nov 24, 2022
* Refs #16253. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Ignoring participants from other processes when they have no locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid announcing locators for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Set TTL to 0 for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid SHM transport for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 865702b)

# Conflicts:
#	src/cpp/rtps/builtin/discovery/participant/PDP.cpp
mergify bot pushed a commit that referenced this pull request Nov 24, 2022
* Refs #16253. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Ignoring participants from other processes when they have no locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid announcing locators for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Set TTL to 0 for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid SHM transport for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 865702b)

# Conflicts:
#	src/cpp/rtps/builtin/discovery/participant/PDP.cpp
mergify bot pushed a commit that referenced this pull request Nov 24, 2022
* Refs #16253. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Ignoring participants from other processes when they have no locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid announcing locators for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Set TTL to 0 for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid SHM transport for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 865702b)

# Conflicts:
#	src/cpp/rtps/builtin/discovery/participant/PDP.cpp
#	src/cpp/rtps/participant/RTPSParticipantImpl.cpp
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2022

backport 2.7.x 2.6.x 2.1.x

✅ Backports have been created

MiguelCompany added a commit that referenced this pull request Dec 2, 2022
* Fix communication with asymmetric ignoreParticipantFlags (#3105)

* Refs #16253. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Ignoring participants from other processes when they have no locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid announcing locators for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Set TTL to 0 for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid SHM transport for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 865702b)

# Conflicts:
#	src/cpp/rtps/builtin/discovery/participant/PDP.cpp

* Fix conflicts

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Added ignore_participant_flags() to Blackbox_FastRTPS PubSubReader. (#3114)

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
mergify bot added a commit that referenced this pull request Dec 2, 2022
* Fix communication with asymmetric ignoreParticipantFlags (#3105)

* Refs #16253. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Ignoring participants from other processes when they have no locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid announcing locators for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Set TTL to 0 for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid SHM transport for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 865702b)

# Conflicts:
#	src/cpp/rtps/builtin/discovery/participant/PDP.cpp

* Fix conflicts

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Added ignore_participant_flags() to Blackbox_FastRTPS PubSubReader. (#3114)

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 6de9842)
mergify bot added a commit that referenced this pull request Dec 2, 2022
* Fix communication with asymmetric ignoreParticipantFlags (#3105)

* Refs #16253. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Ignoring participants from other processes when they have no locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid announcing locators for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Set TTL to 0 for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid SHM transport for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 865702b)

# Conflicts:
#	src/cpp/rtps/builtin/discovery/participant/PDP.cpp

* Fix conflicts

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Added ignore_participant_flags() to Blackbox_FastRTPS PubSubReader. (#3114)

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 6de9842)

# Conflicts:
#	src/cpp/rtps/participant/RTPSParticipantImpl.cpp
MiguelCompany pushed a commit that referenced this pull request Dec 2, 2022
* Fix communication with asymmetric ignoreParticipantFlags (#3105)

* Refs #16253. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Ignoring participants from other processes when they have no locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid announcing locators for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Set TTL to 0 for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid SHM transport for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 865702b)

# Conflicts:
#	src/cpp/rtps/builtin/discovery/participant/PDP.cpp

* Fix conflicts

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Added ignore_participant_flags() to Blackbox_FastRTPS PubSubReader. (#3114)

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 6de9842)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
MiguelCompany added a commit that referenced this pull request Jan 26, 2023
) (#3129)

* Fix communication with asymmetric ignoreParticipantFlags (#3111)

* Fix communication with asymmetric ignoreParticipantFlags (#3105)

* Refs #16253. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Ignoring participants from other processes when they have no locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid announcing locators for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Set TTL to 0 for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #16253. Avoid SHM transport for intraprocess-only participants.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 865702b)

# Conflicts:
#	src/cpp/rtps/builtin/discovery/participant/PDP.cpp

* Fix conflicts

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Added ignore_participant_flags() to Blackbox_FastRTPS PubSubReader. (#3114)

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 6de9842)

# Conflicts:
#	src/cpp/rtps/participant/RTPSParticipantImpl.cpp

* Fixed conflicts

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Fixed build errors on blackbox test

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Remove blackbox regression test which uses a feature in the test transport not implemented in 2.1.x

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants