Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assert in StatefulReader total_unread_ #3172

Closed
wants to merge 3 commits into from
Closed

Add assert in StatefulReader total_unread_ #3172

wants to merge 3 commits into from

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Dec 22, 2022

⚠️ This PR is not meant to be merged!

add assert in StatefulReader
7f3c0a0 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu added no-test Skip CI tests if PR marked with this label skip-ci Automatically pass CI labels Dec 22, 2022
jparisu added 2 commits December 22, 2022 08:13
add assert in DataReaderImpl
8f1d2f8 
Signed-off-by: jparisu <javierparis@eprosima.com>
Add new asserts
34d2cd9 
Signed-off-by: jparisu <javierparis@eprosima.com>
@JLBuenoLopez
Copy link
Contributor

JLBuenoLopez commented Mar 16, 2023 •
edited
Loading

@jparisu If this PR is not meant to be merged... can it be closed? Why was the reason to open it in the first place if it was not intended to be merged? 😅

@jparisu
Copy link
Contributor Author

jparisu commented Mar 21, 2023

Closed in favor of #3203

@jparisu jparisu closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label skip-ci Automatically pass CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jparisu @JLBuenoLopez