-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16192] Fix notification lost #3194
Conversation
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
2120efa
to
19a9f96
Compare
@richiprosima Please test this |
1 similar comment
@richiprosima Please test this |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
e3ed193
to
805820a
Compare
@richiprosima Please test this |
I have confirmed that this PR (#3194) can solve the ros2/rmw_fastrtps#650 issue well. |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
fdc6433
to
5666533
Compare
@richiprosima Please test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@iuhilnehc-ynos since you are original author for the base fix, can you review the code as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 2.8.x 2.7.x |
* fix notification lost Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add a regression test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * rename a variable name and update comments Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify issue Signed-off-by: Chen Lihui <lihui.chen@sony.com> * make the regression test better Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Refs #16192. Fix deadlock on WaitSetImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock on ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Use mutex instead of atomic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock when constructing ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit df2857a) # Conflicts: # src/cpp/fastdds/subscriber/ReadConditionImpl.hpp
* fix notification lost Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add a regression test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * rename a variable name and update comments Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify issue Signed-off-by: Chen Lihui <lihui.chen@sony.com> * make the regression test better Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Refs #16192. Fix deadlock on WaitSetImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock on ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Use mutex instead of atomic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock when constructing ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit df2857a) # Conflicts: # src/cpp/fastdds/subscriber/ReadConditionImpl.hpp
✅ Backports have been created
|
* Fix notification lost (#3194) * fix notification lost Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add a regression test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * rename a variable name and update comments Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify issue Signed-off-by: Chen Lihui <lihui.chen@sony.com> * make the regression test better Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Refs #16192. Fix deadlock on WaitSetImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock on ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Use mutex instead of atomic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock when constructing ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit df2857a) # Conflicts: # src/cpp/fastdds/subscriber/ReadConditionImpl.hpp * Refs #16192. Fixed conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
* Fix notification lost (#3194) * fix notification lost Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add a regression test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * rename a variable name and update comments Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify issue Signed-off-by: Chen Lihui <lihui.chen@sony.com> * make the regression test better Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Refs #16192. Fix deadlock on WaitSetImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock on ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Use mutex instead of atomic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock when constructing ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit df2857a) # Conflicts: # src/cpp/fastdds/subscriber/ReadConditionImpl.hpp * Refs #16192. Fixed conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Description
This is a re-work of #3087, using the original approach by @iuhilnehc-ynos and fixing the deadlocks on ReadConditionImpl.
@Mergifyio backport 2.8.x 2.7.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist