Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16522] Add backports to PR checklist #3197

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

JLBuenoLopez
Copy link
Contributor

Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com

Description

This PR adds a check to ensure the applicable backports are included in the PR description. trying to improve the code maintenance of supported releases.

Contributor Checklist

  • Commit messages follow the project guidelines.
    N/A The code follows the style guidelines of this project.
    N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
    N/A Any new/modified methods have been properly documented using Doxygen.
    N/A Fast DDS test suite has been run locally.
    N/A Changes are ABI compatible.
    N/A Changes are API compatible.
    N/A Documentation builds and tests pass locally.
    N/A New feature has been added to the versions.md file (if applicable).
    N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez added the skip-ci Automatically pass CI label Jan 10, 2023
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 8269eb4 into master Jan 11, 2023
@MiguelCompany MiguelCompany deleted the feature/improve-pr-template-backports branch January 11, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants