Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Instance Handle performance #3204

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Improved Instance Handle performance #3204

wants to merge 2 commits into from

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Jan 11, 2023

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jsan-rt
Added hash function to InstanceHandle. Turned InstanceCollections int…
d71355a 
…o an unordered_map

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Improved comparison operators
0348409 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@JLBuenoLopez
Copy link
Contributor

@jsantiago-eProsima What is the status of this Draft? Can it be closed? Do we need to keep working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsan-rt @JLBuenoLopez