Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16737] RTPSWriter::has_been_fully_delivered implementation #3237

Closed
wants to merge 6 commits into from
Closed

[16737] RTPSWriter::has_been_fully_delivered implementation #3237

wants to merge 6 commits into from

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented Jan 20, 2023 •
edited
Loading

Description

This PR implements RTPSWriter::has_been_fully_delivered API.
This PR depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
    N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
    N/A Documentation builds and tests pass locally.
    N/A New feature has been added to the versions.md file (if applicable).
    N/A New feature has been documented/Current behavior is correctly described in the documentation.
    N/A Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JLBuenoLopez JLBuenoLopez mentioned this pull request Jan 23, 2023
Merged
11 tasks
@JLBuenoLopez JLBuenoLopez force-pushed the feature/on-unacknowledged-sample-removed branch from 4dde7d3 to 9bdc93c Compare January 24, 2023 13:17
@JLBuenoLopez JLBuenoLopez force-pushed the feature/on-unack-sample-removed-RTPSWriter-impl branch from cd0197b to cdad81d Compare January 24, 2023 13:26
@JLBuenoLopez
Copy link
Contributor Author

@richiprosima please test this

@JLBuenoLopez
Copy link
Contributor Author

I have to look into the tests because some times the tests block and timeout. It can be seen in several platforms for the CI run.

@JLBuenoLopez JLBuenoLopez force-pushed the feature/on-unack-sample-removed-RTPSWriter-impl branch from cdad81d to 22e5b86 Compare January 30, 2023 15:18
@JLBuenoLopez
Copy link
Contributor Author

@richiprosima, please test this

@MiguelCompany
Copy link
Member

@JLBuenoLopez-eProsima Now that the tests have been merged, would you mind to rebase here?

@JLBuenoLopez
Refs #16737: ReaderProxy::has_been_delivered
5b0461c 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #16737: add StatelessWriter::is_acked_by_all with sequence numbe…
79b639c 
…r as parameter

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #16737: StatelessWriter::has_been_fully_delivered implementation
df48838 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #16737: StatefulWriter::has_been_fully_delivered implementation
be4346a 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #16737: improve internal documentation
6ad37d5 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #16737: linters
d4015c0 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez force-pushed the feature/on-unack-sample-removed-RTPSWriter-impl branch from 22e5b86 to d4015c0 Compare February 1, 2023 06:02
@JLBuenoLopez
Copy link
Contributor Author

@richiprosima please test this

@JLBuenoLopez
Copy link
Contributor Author

This PR only includes RTPSWriter::has_been_fully_delivered implementation. Consequently, the new DDS Blackbox Listener tests on_unack_sample_removed tests are going to fail in this PR.

I have also rebased #3240 which has also these commits (RTPS implementation) and the DDS/RTPS linkage implementation. @MiguelCompany, maybe you'd rather review directly the complete implementation and close this PR.

@MiguelCompany
Copy link
Member

maybe you'd rather review directly the complete implementation and close this PR.

Yeah. Makes more sense.
Closing this one.

@JLBuenoLopez JLBuenoLopez deleted the feature/on-unack-sample-removed-RTPSWriter-impl branch March 13, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JLBuenoLopez @MiguelCompany