Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds logic for delayed reconciliation of unassociated readers and writers #3545

Closed
wants to merge 1 commit into from
Closed

Adds logic for delayed reconciliation of unassociated readers and writers #3545

wants to merge 1 commit into from

Conversation

cvilas
Copy link
Contributor

@cvilas cvilas commented May 28, 2023

(cherry picked from commit 4bb698e2a23fdc3a4d9907b49064492ffbdc8913)

Description

For a description of the issue resolved here, see #3544

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Vilas Chitrakaran <chitrakaran@arrival.com>

(cherry picked from commit 4bb698e2a23fdc3a4d9907b49064492ffbdc8913)
@EduPonz
Copy link

EduPonz commented Sep 19, 2023

Hi @cvilas, thanks for your contribution. We've talked about this internally and have decided to close the PR for now. This PR is providing a work around for a problem that should not exist in the first place so we think a proper fix for it would be more suitable. In any case, is a good reference should someone want to cherry-pick this work.

@EduPonz EduPonz closed this Sep 19, 2023
@Timple
Copy link

Timple commented Feb 15, 2024

Since I just encountered this issue: has any proper fixing been done in the meantime?

Running ROS2 iron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants