Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19638] Fix clang warnings (backport #3901) #3905

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 6, 2023

This is an automatic backport of pull request #3901 done by Mergify.
Cherry-pick of 462f5d7 has failed:

On branch mergify/bp/2.10.x/pr-3901
Your branch is up to date with 'origin/2.10.x'.

You are currently cherry-picking commit 462f5d741.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CMakeLists.txt
	modified:   examples/cpp/rtps/AsSocket/TestWriterSocket.cpp
	modified:   examples/cpp/rtps/Persistent/TestWriterPersistent.cpp
	modified:   examples/cpp/rtps/Registered/TestWriterRegistered.cpp
	modified:   include/fastdds/rtps/messages/CDRMessage.hpp
	modified:   src/cpp/dynamic-types/DynamicData.cpp
	modified:   src/cpp/fastdds/core/policy/ParameterSerializer.hpp
	modified:   src/cpp/utils/md5.cpp
	modified:   test/blackbox/common/BlackboxTestsDiscovery.cpp
	modified:   test/unittest/security/cryptography/CryptographyPluginTests.hpp
	modified:   test/unittest/xmlparser/XMLEndpointParserTests.cpp
	modified:   test/unittest/xmlparser/XMLParserTests.cpp
	modified:   test/unittest/xmlparser/XMLProfileParserTests.cpp
	modified:   thirdparty/boost/include/boost/intrusive/slist.hpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/unittest/xmlparser/XMLElementParserTests.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Refs #18687. Fix warnings after upgrade clang

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19638: linters

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 462f5d7)

# Conflicts:
#	test/unittest/xmlparser/XMLElementParserTests.cpp
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Oct 6, 2023
@mergify mergify bot mentioned this pull request Oct 6, 2023
7 tasks
@JLBuenoLopez JLBuenoLopez added this to the v2.10.3 milestone Oct 6, 2023
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Copy link
Contributor

@richiprosima please test this

@JLBuenoLopez JLBuenoLopez added ci-pending PR which CI is running and removed conflicts Backport PR wich git cherry pick failed labels Oct 6, 2023
@JLBuenoLopez
Copy link
Contributor

@richiprosima please test mac

@JLBuenoLopez
Copy link
Contributor

CI Mac failures are unrelated and the warnings are fixed.

@MiguelCompany MiguelCompany merged commit 520439b into 2.10.x Oct 6, 2023
1 of 4 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.10.x/pr-3901 branch October 6, 2023 09:17
@EduPonz EduPonz removed the ci-pending PR which CI is running label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants