Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19638] Log error message upon receiver resource creation failure (backport #3924) #3936

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 17, 2023

This is an automatic backport of pull request #3924 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 77a85dd)
@MiguelCompany MiguelCompany added this to the v2.11.3 milestone Oct 17, 2023
@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Oct 17, 2023
@MiguelCompany MiguelCompany merged commit 6ffa92b into 2.11.x Oct 18, 2023
8 of 12 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.11.x/pr-3924 branch October 18, 2023 06:54
@iuhilnehc-ynos
Copy link
Contributor

I am afraid it's not a correct fix as ROS2 applications encounter issues about the ERROR LOG by default setting.

chenlh ros2-master $ ros2 run demo_nodes_cpp talker
[INFO] [1697637931.647738644] [talker]: Publishing: 'Hello World: 1'
[INFO] [1697637932.647659641] [talker]: Publishing: 'Hello World: 2'
[INFO] [1697637933.647628887] [talker]: Publishing: 'Hello World: 3'
[INFO] [1697637934.647612741] [talker]: Publishing: 'Hello World: 4'
[INFO] [1697637935.647655783] [talker]: Publishing: 'Hello World: 5'
[INFO] [1697637936.647698342] [talker]: Publishing: 'Hello World: 6'
^C[INFO] [1697637936.756977153] [rclcpp]: signal_handler(signum=2)

chenlh ros2-master $ ros2 run demo_nodes_cpp listener
2023-10-18 22:05:33.648 [RTPS_PARTICIPANT Error] Could not create the specified receiver resource -> Function createReceiverResources
2023-10-18 22:05:33.649 [RTPS_PARTICIPANT Error] Could not create the specified receiver resource -> Function createReceiverResources
[INFO] [1697637934.648246861] [listener]: I heard: [Hello World: 4]
[INFO] [1697637935.648237591] [listener]: I heard: [Hello World: 5]
^C[INFO] [1697637936.117055349] [rclcpp]: signal_handler(signum=2)

@MiguelCompany
Copy link
Member

@iuhilnehc-ynos See #3955 for a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants