Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20215] Update PR checklist template. Backports and Description #4215

Merged
merged 1 commit into from
Jan 10, 2024
Merged

[20215] Update PR checklist template. Backports and Description #4215

merged 1 commit into from
Jan 10, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jan 9, 2024 •
edited by EduPonz
Loading

Description

This PR updates the PR's contribution template

  • To check for PR's title and description correctness.
  • Update the backports list.

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL
Refs #20215: Update PR template to include check for PR description, …
4405f43 
…title and backports

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added the skip-ci Automatically pass CI label Jan 9, 2024
@Mario-DL Mario-DL modified the milestones: v2.13.1, v2.13.2 Jan 9, 2024
@EduPonz EduPonz modified the milestones: v2.13.2, v2.13.1 Jan 10, 2024
@EduPonz EduPonz merged commit dbbb465 into master Jan 10, 2024
10 checks passed
@EduPonz EduPonz deleted the update/pr-checklist branch January 10, 2024 06:56
@EduPonz
Copy link

EduPonz commented Jan 10, 2024

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2024 •
edited
Loading

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@Mario-DL @mergify
Update PR template to include check for PR description, title and bac…
0235291 
…kports (#4215)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit dbbb465)
@mergify mergify bot mentioned this pull request Jan 10, 2024
Merged
@mergify mergify bot mentioned this pull request Jan 10, 2024
Merged
@mergify mergify bot mentioned this pull request Jan 10, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@Mario-DL @mergify
Update PR template to include check for PR description, title and bac…
caab544 
…kports (#4215)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit dbbb465)

# Conflicts:
#	.github/pull_request_template.md
@mergify mergify bot mentioned this pull request Jan 10, 2024
Merged
EduPonz pushed a commit that referenced this pull request Jan 10, 2024
@Mario-DL @EduPonz
Update PR template to include check for PR description, title and bac…
69fd2d0 
…kports (#4215)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit dbbb465)
EduPonz pushed a commit that referenced this pull request Jan 10, 2024
@mergify @Mario-DL
Update PR template to include check for PR description, title and bac…
1ec6020 
…kports (#4215) (#4223)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit dbbb465)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
JesusPoderoso pushed a commit that referenced this pull request Jan 10, 2024
@Mario-DL @JesusPoderoso
Update PR template to include check for PR description, title and bac…
9505c95 
…kports (#4215)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit dbbb465)
JesusPoderoso pushed a commit that referenced this pull request Jan 10, 2024
@mergify @Mario-DL
Update PR template to include check for PR description, title and bac…
f937405 
…kports (#4215) (#4222)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit dbbb465)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
JesusPoderoso pushed a commit that referenced this pull request Jan 10, 2024
@mergify @Mario-DL @MiguelCompany
Update PR checklist template. Backports and Description (#4215) (#4224)
5541897 
* Update PR template to include check for PR description, title and backports (#4215)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit dbbb465)

# Conflicts:
#	.github/pull_request_template.md

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Jan 11, 2024
@mergify @Mario-DL
Update PR template to include check for PR description, title and bac…
7ca25f2 
…kports (#4215) (#4221)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit dbbb465)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
@duca duca mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @EduPonz