Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20121] Remove unnecessary TCP warning #4217

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[20121] Remove unnecessary TCP warning #4217

merged 1 commit into from
Jan 22, 2024

Conversation

jepemi
Copy link
Contributor

@jepemi jepemi commented Jan 9, 2024 •
edited by MiguelCompany
Loading

Description

When sending TCP messages, the locator selector from the publisher includes the locators to which messages will be sent. These locators are compared with the send_resource_list_. If there are more than two endpoints available (locators A and B), the following checks are made: A==A, A==B, B==A, B==B.

Successful checks end in trying to send data to the correspondent locator.
Mismatching checks produce a warning, though it is actually correct behavior.

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jepemi jepemi force-pushed the bugfix/remove_send_unnecessary_warning branch from 1bb9ffc to ce1f0dd Compare January 9, 2024 08:38
@jepemi
Copy link
Contributor Author

jepemi commented Jan 9, 2024

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2024 •
edited
Loading

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

@jepemi jepemi marked this pull request as ready for review January 9, 2024 09:03
@EduPonz EduPonz added this to the v2.13.2 milestone Jan 10, 2024
@jepemi jepemi force-pushed the bugfix/remove_send_unnecessary_warning branch from ce1f0dd to 7cda21f Compare January 12, 2024 08:55
@jepemi
Copy link
Contributor Author

jepemi commented Jan 16, 2024

@richiprosima please test this

@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Jan 16, 2024
@jepemi
Copy link
Contributor Author

jepemi commented Jan 17, 2024

@richiprosima please test mac test discovery_server_linux

@jepemi
Refs #20121: Remove unnecessary warning
26a3402 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi jepemi force-pushed the bugfix/remove_send_unnecessary_warning branch from 7cda21f to 26a3402 Compare January 18, 2024 09:53
@jepemi
Copy link
Contributor Author

jepemi commented Jan 18, 2024

@richiprosima please test this

@MiguelCompany MiguelCompany merged commit ab94226 into master Jan 22, 2024
10 of 14 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/remove_send_unnecessary_warning branch January 22, 2024 14:25
mergify bot pushed a commit that referenced this pull request Jan 22, 2024
@jepemi @mergify
Remove unnecessary warning (#4217)
336896d 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)
mergify bot pushed a commit that referenced this pull request Jan 22, 2024
@jepemi @mergify
Remove unnecessary warning (#4217)
60a93de 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)
mergify bot pushed a commit that referenced this pull request Jan 22, 2024
@jepemi @mergify
Remove unnecessary warning (#4217)
942eaa9 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)
This was referenced Jan 22, 2024
Merged
Merged
Merged
@mergify mergify bot mentioned this pull request Jan 22, 2024
Merged
JesusPoderoso pushed a commit that referenced this pull request Jan 22, 2024
@jepemi @JesusPoderoso
Remove unnecessary warning (#4217)
a37133e 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)
EduPonz pushed a commit that referenced this pull request Jan 25, 2024
@mergify @jepemi
Remove unnecessary warning (#4217) (#4274)
b414751 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)

Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request Jan 27, 2024
@jepemi @EduPonz
Remove unnecessary warning (#4217)
0ca4b5e 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)
MiguelCompany pushed a commit that referenced this pull request Jan 29, 2024
@mergify @jepemi
Remove unnecessary TCP warning (#4217) (#4272)
e9a37b5 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)

Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request Feb 1, 2024
@mergify @jepemi
Remove unnecessary warning (#4217) (#4273)
3225135 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)

Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>
jepemi added a commit that referenced this pull request Feb 23, 2024
@jepemi
Remove unnecessary warning (#4217)
796d5a6 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)
EduPonz pushed a commit that referenced this pull request Feb 29, 2024
@mergify @jepemi @Mario-DL
Remove unnecessary TCP warning & Fix some tests (#4217) (#4275)
464de2d 
* Remove unnecessary warning (#4217)

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)

* Refs #20485: Fix tests using PubSubParticipant

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20485: PubSubBasic test fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>
Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
EduPonz pushed a commit that referenced this pull request Mar 6, 2024
@mergify @jepemi
Fix wrong log info messages on TCP (#4258) (#4314)
89b4f17 
* Remove unnecessary warning (#4217)

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)

* Fix wrong log info messages on TCP (#4258)

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

# Conflicts:
#	src/cpp/rtps/transport/TCPTransportInterface.cpp

* Refs #20262: Resolve conflicts

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

---------

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>
Co-authored-by: Jesus Perez <jesusperez@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jepemi @MiguelCompany @EduPonz