Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization for Log::Kind to ostream #4292

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Conversation

LuciaEchevarria99
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented Jan 25, 2024

Add serialization for Log::Kind to ostream

Description

This commit introduces a new ostream serialization function for the Log::Kind enumeration, allowing seamless output to ostream objects. The function includes a switch statement of Log::Kind values to their corresponding string representations (INFO, WARNING, ERROR).

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@LuciaEchevarria99 LuciaEchevarria99 added the no-test Skip CI tests if PR marked with this label label Jan 25, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use this in LogConsumer::print_header

@EduPonz EduPonz removed the no-test Skip CI tests if PR marked with this label label Jan 25, 2024
@EduPonz
Copy link

EduPonz commented Jan 27, 2024

@LuciaEchevarria99 please address uncrustify failure

Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI 🏅

@EduPonz EduPonz removed the to-do label Feb 7, 2024
@JesusPoderoso
Copy link
Contributor

@Mergifyio rebase

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Copy link
Contributor

mergify bot commented Feb 8, 2024

rebase

✅ Branch has been successfully rebased

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Feb 8, 2024
@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac please test linux

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Feb 9, 2024
@EduPonz EduPonz merged commit ec3cdcd into master Feb 10, 2024
13 of 15 checks passed
@EduPonz EduPonz deleted the feature/logKind-stream branch February 10, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants