-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20262] Fix wrong log info messages on TCP (backport #4258) #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
JesusPoderoso
added
ci-pending
PR which CI is running
and removed
conflicts
Backport PR wich git cherry pick failed
labels
Jan 29, 2024
@richiprosima plase test this |
@richiprosima please test linux please test mac |
@richiprosima please test linux please test mac 😠 |
@Mergifyio rebase |
Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit 36f7f57) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.11.x/pr-4258
branch
from
February 1, 2024 10:15
efc70fb
to
48ed040
Compare
MiguelCompany
approved these changes
Feb 1, 2024
@richiprosima please test linux please test mac |
@richiprosima please test linux |
@richiprosima please test mac |
CI issues unrelated, Ready-to-merge! |
JesusPoderoso
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-test
Skip CI tests if PR marked with this label
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4258 done by Mergify.
Cherry-pick of 36f7f57 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com