Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19587] Include variety of terminate proccess signals handler in discovery server (backport #4278) #4334

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 30, 2024

This is an automatic backport of pull request #4278 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…rver (#4278)

* Refs #19587: Include SIGHUP handler

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19587: Handle more signals

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19587: Move proper signals to 'linux only' case

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19587: Apply Miguel suggestion

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19587: Fix Windows build

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 6eb1170)
@Mario-DL
Copy link
Member

@richiprosima please test mac

@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Feb 20, 2024
@Mario-DL
Copy link
Member

Mario-DL commented Mar 6, 2024

@Mergifyio rebase 2.6.x

Copy link
Contributor Author

mergify bot commented Mar 6, 2024

rebase 2.6.x

❌ Unable to rebase: user Mario-DL is unknown.

Please make sure Mario-DL has logged in Mergify dashboard.

@Mario-DL
Copy link
Member

Mario-DL commented Mar 6, 2024

Since it is only mac pending, I am asking for the jenkins one instead of rebasing. Changes in this PR are also minimal

@Mario-DL
Copy link
Member

Mario-DL commented Mar 6, 2024

@richiprosima please test mac

@Mario-DL
Copy link
Member

Mario-DL commented Mar 7, 2024

Failed tests are unrelated, ready to merge

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 7, 2024
@EduPonz EduPonz merged commit d439237 into 2.6.x Mar 7, 2024
9 of 17 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.6.x/pr-4278 branch March 7, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants