Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20272] Update Fast DDS types with Fast DDS Gen to include <cstdint> in v1 types #4340

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

Mario-DL
Copy link
Member

Description

This PR updates the Fast DDS types with Fast DDS Gen (compiled with the eProsima/Fast-DDS-Gen#290 fix) that includes the <cstdint> header in v1 types. It is required to correctly compile against Fast CDR v1 with gcc 13.2.0 (#4337).

I checked the compilation in an Ubuntu 24.04 (gcc 13.2.0) with both, tests enabled and disabled, and it solves the issue.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added the no-test Skip CI tests if PR marked with this label label Jan 31, 2024
@Mario-DL Mario-DL added this to the v2.13.2 milestone Jan 31, 2024
@EduPonz EduPonz modified the milestones: v2.13.2, v2.13.3 Feb 1, 2024
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Feb 8, 2024
@Mario-DL Mario-DL removed the needs-review PR that is ready to be reviewed label Feb 8, 2024
@MiguelCompany
Copy link
Member

@Mergifyio rebase

…int> header in v1 types

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Copy link
Contributor

mergify bot commented Feb 8, 2024

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Feb 8, 2024
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@MiguelCompany
Copy link
Member

I think we can merge this, but I also think we can fix some of the uncrustify failures in the code generator.
At least the ones in the doxygen comments indentation

@MiguelCompany MiguelCompany merged commit d891ffc into master Feb 9, 2024
10 of 13 checks passed
@MiguelCompany MiguelCompany deleted the update/cstdint_v1types branch February 9, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants