-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20272] Update Fast DDS types with Fast DDS Gen to include <cstdint> in v1 types #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
MiguelCompany
requested changes
Feb 8, 2024
@Mergifyio rebase |
…int> header in v1 types Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
MiguelCompany
force-pushed
the
update/cstdint_v1types
branch
from
February 8, 2024 12:19
67941c2
to
3afaadb
Compare
✅ Branch has been successfully rebased |
MiguelCompany
approved these changes
Feb 8, 2024
@richiprosima Please test this |
@richiprosima please test this |
I think we can merge this, but I also think we can fix some of the uncrustify failures in the code generator. |
This was referenced Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Fast DDS types with Fast DDS Gen (compiled with the eProsima/Fast-DDS-Gen#290 fix) that includes the
<cstdint>
header in v1 types. It is required to correctly compile against Fast CDR v1 withgcc 13.2.0
(#4337).I checked the compilation in an
Ubuntu 24.04
(gcc 13.2.0
) with both, tests enabled and disabled, and it solves the issue.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist