-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20180] TCP Client&Server Participant Decision-Making (backport #4277) #4386
Conversation
4b38228
to
c8c2f35
Compare
c8c2f35
to
2a5ba90
Compare
I am asking for ci when the other TCP-related PRs are merged |
2a5ba90
to
566bbb9
Compare
566bbb9
to
88fe9f3
Compare
755abc6
to
ce11371
Compare
* Refs #20180: Spelling fix Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Create function to check pending_logical_ports Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Add new TCP Connection type Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Add new method to enable TCP channel after connection in LARGE DATA Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Refactor OpenOutputChannel method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Include LARGE DATA logic in SocketAccepted method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Include LARGE DATA logic in processBindConnectionRequest method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Add new TCP connection and methods SECURITY Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Add SECURITY support to OpenOutputChannel Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Bugfix setting environment variable in tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Add multicast IPv6 to LARGE_DATA locator Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Add TCP test in LARGE_DATA Topology Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Clean code & Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Modified participant populated test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20180: Add new api to update channels Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Refactor OpenOutputChannel with new channel map Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Refactor bind_socket with new channel map Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Refactor SocketAccepted with new channel map (Revert to old behavior) Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Refactor CloseOutputChannel to support cases with new channel map Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Update Secure channel logic with new channel map Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Use same IPv6 as defaultMetatrafficMulticast Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Refactor using locator inside sender resource instead of channel Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Data races associated Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Apply suggestions to tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20180: Add OpenLogicalPortRequest scenario before Bind Response is processed Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180. Remove unnecessary methods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20180. Early exit when logical_port is 0. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20180. Refactor to avoid lambda. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20180. Minor changes. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20180. Simplify with WanToLanLocator. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20180: Apply suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Revert "Refs #20180: Add new TCP Connection type" This reverts commit 4b4eb4153553cfdbf007896ff524d3e904f722c9. Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Remove unnecessary lock Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Revert "Refs #20180: Add new TCP connection and methods SECURITY" This reverts commit c69d92e56dcfab3c3c7287145a7a93e57947d3cb. Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180: Fix test (file descriptors limit) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20180: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20180. Fix port comparison. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #20180: Fix double lock and update old test with current behavior Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20180: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20180: Fix windows test build Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20180: Apply test suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20180: Bugfix with cv in receiver_resources_ destruction Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20180. Delete participant on failing ParticipantTests.ParticipantCreationWithBuiltinTransport Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_DATA. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Jesus Perez <jesusperez@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 709b140)
88fe9f3
to
c3e6242
Compare
@richiprosima please test this |
It seems that linux test failure may be related |
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
c3e6242
to
b4acd76
Compare
@richiprosima please test this |
Failed tests in github cis are unrelated. Jenkins ci perfectly passed, giving it as ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is an automatic backport of pull request #4277 done by Mergify.
Cherry-pick of 709b140 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com