Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20510] Remove FASTDDS_TODO_BEFORE 2.14 #4445

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 23, 2024

Description

This PR removes a FASTDDS_TODO_BEFORE 2.14 since it's preventing compilation. I will be addressed in a follow up before the v2.14.0 release

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.14.0 milestone Feb 23, 2024
@EduPonz
Copy link
Author

EduPonz commented Feb 23, 2024

@richiprosima please test this

@EduPonz EduPonz merged commit 31a83ca into master Feb 23, 2024
13 of 17 checks passed
@EduPonz EduPonz deleted the hotfix/todo-before-2.14 branch February 23, 2024 21:39
@EduPonz
Copy link
Author

EduPonz commented Feb 24, 2024

TODO has been addressed in #4299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants