Fix warnings when compiling for Windows x86 [20519]

src/cpp/utils/threading/threading_win32.ipp

@@ -21,12 +21,13 @@
 
 namespace eprosima {
 
-template<typename... Args>
+template<typename ... Args>
 static void set_name_to_current_thread_impl(
-    const char* fmt, Args... args)
+        const char* fmt,
+        Args... args)
 {
     char thread_name[16]{};
-    snprintf(thread_name, 16, fmt, args...);
+    snprintf(thread_name, 16, fmt, args ...);
 
     std::wstringstream stream;
     stream << thread_name;
@@ -63,7 +64,8 @@ static void configure_current_thread_priority(
     {
         if (0 == SetThreadPriority(GetCurrentThread(), priority))
         {
-            EPROSIMA_LOG_ERROR(SYSTEM, "Error '" << GetLastError() << "' configuring priority for thread " << GetCurrentThread());
+            EPROSIMA_LOG_ERROR(SYSTEM,
+                    "Error '" << GetLastError() << "' configuring priority for thread " << GetCurrentThread());
         }
     }
 }
@@ -73,9 +75,10 @@ static void configure_current_thread_affinity(
 {
     if (affinity_mask != 0)
     {
-        if (0 == SetThreadAffinityMask(GetCurrentThread(), affinity_mask))
+        if (0 == SetThreadAffinityMask(GetCurrentThread(), static_cast<DWORD_PTR>(affinity_mask)))
         {
-            EPROSIMA_LOG_ERROR(SYSTEM, "Error '" << GetLastError() << "' configuring affinity for thread " << GetCurrentThread());
+            EPROSIMA_LOG_ERROR(SYSTEM,
+                    "Error '" << GetLastError() << "' configuring affinity for thread " << GetCurrentThread());
         }
     }
 }

test/blackbox/api/dds-pim/PubSubReader.hpp

@@ -575,7 +575,7 @@ class PubSubReader
                 {
                     return current_unread_count_ >= n_unread;
                 });
-        return current_unread_count_;
+        return static_cast<size_t>(current_unread_count_);
     }
 
     void block(

test/blackbox/common/BlackboxTestsNetworkConf.cpp

@@ -429,7 +429,7 @@ TEST_P(NetworkConfig, PubSubAsymmetricInterfaceWhitelistLocalhostOnly)
 {
 #ifdef _WIN32
     GTEST_SKIP() << "This test is skipped on Windows";
-#endif // _WIN32
+#else
     std::vector<IPFinder::info_IP> no_interfaces;
 
     std::vector<IPFinder::info_IP> locahost_interface_only;
@@ -481,6 +481,7 @@ TEST_P(NetworkConfig, PubSubAsymmetricInterfaceWhitelistLocalhostOnly)
             interface_whitelist_test(no_interfaces, locahost_interface_only, true);
         }
     }
+#endif // _WIN32
 }
 
 // Regression test for redmine issue #18854 to check in UDP that setting the interface whitelist in one

test/blackbox/common/BlackboxTestsTransportUDP.cpp

@@ -524,7 +524,7 @@ void deliver_datagram_from_file(
     std::basic_ifstream<char> file(filename, std::ios::binary | std::ios::in);
 
     file.seekg(0, file.end);
-    size_t file_size = file.tellg();
+    size_t file_size = static_cast<size_t>(file.tellg());
     file.seekg(0, file.beg);
 
     std::vector<uint8_t> buf(file_size);

test/blackbox/common/DDSBlackboxTestsMonitorService.cpp

@@ -835,12 +835,8 @@ struct ConnectionListSampleValidator : public SampleValidator
 
                                     return expected_locators_found;
                                 }
-                                else
-                                {
-                                    return false;
-                                }
 
-                                return true;
+                                return false;
                             });
 
             ASSERT_NE(it, total_msgs.end());