[20529] Fix CI documentation workflow label triggering #4456

JesusPoderoso · 2024-02-27T09:23:16Z

Description

This PR fixes the label triggering of the documentation CI workflow. Before, it was set to avoid the workflow if the label no-test was added, but that was not the intended use. With this PR, no-test label triggers the job, while skip-ci label does not.

Furthermore, this PR also refactors the documentation-test workflow to use eProsima-CI. This PR depends on:

[20529] Add skip_existing option to vcs_import action eProsima-CI#63

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
N/A The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Changes are ABI compatible.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

.github/workflows/documentation-tests.yaml

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

JesusPoderoso

Commits from 77befa7 to 693a6a0 LGTM
( 77befa7, 1d8501d, 4e11f46, 693a6a0)

EduPonz · 2024-02-29T07:04:07Z

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

mergify · 2024-02-29T07:04:11Z

backport 2.13.x 2.12.x 2.10.x 2.6.x

✅ Backports have been created

#4468 [20529] Fix CI documentation workflow label triggering (backport #4456) has been created for branch 2.13.x
#4469 [20529] Fix CI documentation workflow label triggering (backport #4456) has been created for branch 2.12.x
#4470 [20529] Fix CI documentation workflow label triggering (backport #4456) has been created for branch 2.10.x
#4471 [20529] Fix CI documentation workflow label triggering (backport #4456) has been created for branch 2.6.x

* Refs #20529: Fix documentation workflow label triggering Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20529: Refactor documentation-tests workflow to use eProsima-CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add workspace to colcon_build and colcon_test actions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Set eProsima-CI actions to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add .meta and specify all colcon action args Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit c4dbe83)

* Refs #20529: Fix documentation workflow label triggering Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20529: Refactor documentation-tests workflow to use eProsima-CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add workspace to colcon_build and colcon_test actions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Set eProsima-CI actions to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add .meta and specify all colcon action args Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit c4dbe83) Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>

* Refs #20529: Fix documentation workflow label triggering Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20529: Refactor documentation-tests workflow to use eProsima-CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add workspace to colcon_build and colcon_test actions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Set eProsima-CI actions to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add .meta and specify all colcon action args Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit c4dbe83)

* Refs #20529: Fix documentation workflow label triggering Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20529: Refactor documentation-tests workflow to use eProsima-CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add workspace to colcon_build and colcon_test actions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Set eProsima-CI actions to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add .meta and specify all colcon action args Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit c4dbe83) Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>

* Refs #20529: Fix documentation workflow label triggering Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20529: Refactor documentation-tests workflow to use eProsima-CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add workspace to colcon_build and colcon_test actions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Set eProsima-CI actions to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add .meta and specify all colcon action args Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit c4dbe83)

* Fix CI documentation workflow label triggering (#4456) * Refs #20529: Fix documentation workflow label triggering Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20529: Refactor documentation-tests workflow to use eProsima-CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add workspace to colcon_build and colcon_test actions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Set eProsima-CI actions to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add .meta and specify all colcon action args Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit c4dbe83) * Refs #20529: Fix doc issue in 2.6.x Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20529: Fix documentation workflow label triggering Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20529: Refactor documentation-tests workflow to use eProsima-CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add workspace to colcon_build and colcon_test actions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Set eProsima-CI actions to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20529: Add .meta and specify all colcon action args Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit c4dbe83) Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20542: Fix CI version management Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Apply internal revision suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Add ignored paths to sanitizer events Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Remove nightly files Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Remove Windows CI test report Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Remove unused action Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Set default Discovery Server latest TAG Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Address last rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Fix input branch on reusable windows CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Manual cherry-pick of PR #4549 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Manual cherry-pick of PR #4456 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Fix a couple of nitpicks Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>

JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Feb 27, 2024

JesusPoderoso added this to the v2.14.0 milestone Feb 27, 2024

JesusPoderoso self-assigned this Feb 27, 2024

EduPonz force-pushed the hotfix/ci_documentation branch from 4b72cc1 to e69dbfe Compare February 27, 2024 09:46

EduPonz changed the title ~~[20486] Fix CI documentation workflow label triggering~~ [20529] Fix CI documentation workflow label triggering Feb 27, 2024

This comment was marked as outdated.

Sign in to view

JesusPoderoso commented Feb 27, 2024

View reviewed changes

.github/workflows/documentation-tests.yaml Outdated Show resolved Hide resolved

EduPonz force-pushed the hotfix/ci_documentation branch 2 times, most recently from 34e2b90 to 8390649 Compare February 28, 2024 06:18

This comment was marked as outdated.

Sign in to view

JesusPoderoso and others added 4 commits February 28, 2024 20:20

Refs #20529: Fix documentation workflow label triggering

55b75a9

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #20529: Refactor documentation-tests workflow to use eProsima-CI

77befa7

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20529: Add workspace to colcon_build and colcon_test actions

1d8501d

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20529: Set eProsima-CI actions to v0

4e11f46

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz force-pushed the hotfix/ci_documentation branch from 74bb931 to cdd95eb Compare February 28, 2024 19:22

Refs #20529: Add .meta and specify all colcon action args

693a6a0

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz force-pushed the hotfix/ci_documentation branch from cdd95eb to 693a6a0 Compare February 29, 2024 05:56

JesusPoderoso commented Feb 29, 2024

View reviewed changes

EduPonz added skip-ci Automatically pass CI and removed no-test Skip CI tests if PR marked with this label skip-ci Automatically pass CI labels Feb 29, 2024

EduPonz approved these changes Feb 29, 2024

View reviewed changes

elianalf approved these changes Feb 29, 2024

View reviewed changes

EduPonz merged commit c4dbe83 into master Feb 29, 2024
7 of 10 checks passed

EduPonz deleted the hotfix/ci_documentation branch February 29, 2024 07:04

mergify bot mentioned this pull request Feb 29, 2024

[20529] Fix CI documentation workflow label triggering (backport #4456) #4468

Closed

mergify bot mentioned this pull request Feb 29, 2024

[20529] Fix CI documentation workflow label triggering (backport #4456) #4469

Merged

mergify bot mentioned this pull request Feb 29, 2024

[20529] Fix CI documentation workflow label triggering (backport #4456) #4470

Merged

mergify bot mentioned this pull request Feb 29, 2024

[20529] Fix CI documentation workflow label triggering (backport #4456) #4471

Merged

EduPonz added a commit that referenced this pull request Mar 13, 2024

Refs #20542: Manual cherry-pick of PR #4456

5386558

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20529] Fix CI documentation workflow label triggering #4456

[20529] Fix CI documentation workflow label triggering #4456

JesusPoderoso commented Feb 27, 2024 •

edited by EduPonz

Loading

This comment was marked as outdated.

This comment was marked as outdated.

JesusPoderoso left a comment

EduPonz commented Feb 29, 2024

mergify bot commented Feb 29, 2024 •

edited

Loading

[20529] Fix CI documentation workflow label triggering #4456

[20529] Fix CI documentation workflow label triggering #4456

Conversation

JesusPoderoso commented Feb 27, 2024 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

This comment was marked as outdated.

This comment was marked as outdated.

JesusPoderoso left a comment

Choose a reason for hiding this comment

EduPonz commented Feb 29, 2024

mergify bot commented Feb 29, 2024 • edited Loading

✅ Backports have been created

JesusPoderoso commented Feb 27, 2024 •

edited by EduPonz

Loading

mergify bot commented Feb 29, 2024 •

edited

Loading