-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20120] TCPSendResources cleanup (backport #4300) #4513
Conversation
Cherry-pick of fe11650 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
9554040
to
05c889a
Compare
0fb138c
to
ab52f60
Compare
@jepemi as a stretch goal, we may merge this one if we manage to solve the conflicts and successfully run ci |
05c889a
to
8b9a329
Compare
@richiprosima please test this |
Windows CI complains about a missing include |
@jepemi would you mind taking a look at this ? We are close to merging |
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
8b9a329
to
e26e7fd
Compare
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
807d8b9
to
b1e2cf0
Compare
@richiprosima please test this |
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@richiprosima please test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM unrelated failed tests
This is an automatic backport of pull request #4300 done by Mergify.
Cherry-pick of fe11650 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com