-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20508] TCP first message loss (backport #4454) #4560
Conversation
Cherry-pick of 8103cf0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@jepemi could you address the conflicts, please? (If you don't mind, try to remove the |
ce70d5f
to
5ee5393
Compare
5ee5393
to
b8d7702
Compare
This comment was marked as outdated.
This comment was marked as outdated.
* Refs #20508: add remaining add_logical_port calls Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox tests + functional fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add cv + fix windows tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508. Use lock_guard where apropiate. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Proxy is_local_port_opened. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Refactor wait_logical_port_under_negotiation. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix typo Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - firs message loss related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - transport descriptor related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Change timeout behavior Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix xml parser Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Undo fastcdr commit change Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
b8d7702
to
673328e
Compare
@richiprosima please test this |
@richiprosima please test mac |
Even though Mac CI has not run in Jenkins, the other CI issues are unrelated to this PR. |
Description
In the initial TCP logical port negotiation some logical port requests were missing. This would not prevent communication as those remaining requests would be sent on the first data sent to that logical port. However, that data would be discarded.
With this PR all discovered logical ports are requested on initialization and the first data would not need to be discarded.
@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Related documentation PR: [20508] TCP first message loss Fast-DDS-docs#699
Reviewer Checklist
This is an automatic backport of pull request #4454 done by [Mergify](https://mergify.com).