-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20508] TCP first message loss (backport #4454) #4563
Conversation
Cherry-pick of 8103cf0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
e5d65ee
to
2a499a4
Compare
@richiprosima please test this |
@jepemi could you take a look to the conflicts here ? I think that this PR can be in for the upcoming release this week ! |
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
2a499a4
to
6720de7
Compare
@richiprosima please test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The TransportTCP.large_data_topology.Transport
fails in a couple of cis, I have occasionally seen it failing in another PRs. Just to be sure, I have run it multiple times in local (~20) and it did not fail. Approving !
Description
In the initial TCP logical port negotiation some logical port requests were missing. This would not prevent communication as those remaining requests would be sent on the first data sent to that logical port. However, that data would be discarded.
With this PR all discovered logical ports are requested on initialization and the first data would not need to be discarded.
@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Related documentation PR: [20508] TCP first message loss Fast-DDS-docs#699
Reviewer Checklist
This is an automatic backport of pull request #4454 done by [Mergify](https://mergify.com).