Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20625] Monitor service properly managing instances #4564

Merged
merged 5 commits into from
Mar 25, 2024
Merged

[20625] Monitor service properly managing instances #4564

merged 5 commits into from
Mar 25, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Mar 15, 2024 •
edited
Loading

Description

This PR fixes a misbehavior of the monitor service that was not truly managing instances since it requires a DataWriterHistory instead of a WriterHistory. Cachechanges owned by instances are now properly removed in successive updates to the same instance.

@Mergifyio backport 2.13.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v2.14.1 milestone Mar 15, 2024
Base automatically changed from ci/fix_cmake_sanitizer_workflows to master March 15, 2024 17:03
@Mario-DL Mario-DL closed this Mar 15, 2024
@Mario-DL Mario-DL reopened this Mar 15, 2024
@Mario-DL
Refs #20625: Add BB tests
db3caee 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #20625: Add Monitor Service Fix. Use DataWriterHistory
bb62db5 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #20625: Fix MonitorService Unittests
759bfaa 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Copy link
Member Author

@richiprosima please test this

@Mario-DL
Refs #20625: Apply rev suggestion
f1bc8ba 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Copy link
Member Author

@richiprosima please test this

@Mario-DL
Refs #20625: Add more comments in BB tests
f061f0f 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Copy link
Member Author

@richiprosima please test this

@EduPonz
Copy link

EduPonz commented Mar 25, 2024

@Mergifyio backport 2.13.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 25, 2024 •
edited
Loading

backport 2.13.x

✅ Backports have been created

@EduPonz EduPonz merged commit 84960eb into master Mar 25, 2024
12 of 16 checks passed
@EduPonz EduPonz deleted the hotfix/20625 branch March 25, 2024 08:59
mergify bot pushed a commit that referenced this pull request Mar 25, 2024
@Mario-DL @mergify
Monitor service properly managing instances (#4564)
a6280de 
* Refs #20625: Add BB tests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20625: Add Monitor Service Fix. Use DataWriterHistory

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20625: Fix MonitorService Unittests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20625: Apply rev suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20625: Add more comments in BB tests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 84960eb)

# Conflicts:
#	test/unittest/statistics/rtps/CMakeLists.txt
@mergify mergify bot mentioned this pull request Mar 25, 2024
Merged
12 tasks
EduPonz pushed a commit that referenced this pull request Mar 28, 2024
@mergify @Mario-DL @JesusPoderoso
Monitor service properly managing instances (#4564) (#4612)
6d39ec1 
* Monitor service properly managing instances (#4564)

* Refs #20625: Add BB tests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20625: Add Monitor Service Fix. Use DataWriterHistory

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20625: Fix MonitorService Unittests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20625: Apply rev suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20625: Add more comments in BB tests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 84960eb)

# Conflicts:
#	test/unittest/statistics/rtps/CMakeLists.txt

* Fix conflicts

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf elianalf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @EduPonz @elianalf