Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187) #4608

Merged
merged 6 commits into from
May 28, 2024

Commits on May 24, 2024

  1. Handle errors when setting socket buffer sizes (#4760) (#4796)

    * Refs #20972. Method socket_buffer_size in DDS_PIM helpers sets also sending buffer.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Method socket_buffer_size in fastrtps_deprecated helpers sets also sending buffer.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Improvements in on_sample_lost blackbox tests.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Move code into new private methods.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Refactor on configure_send_buffer_size.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Refactor on configure_receive_buffer_size.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Check user configuration at the beginning of init method.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Use maxMessageSize as minimum possible value.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Applying changes on OpenAndBindUnicastOutputSocket.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Applying changes on CreateInputChannelResource.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Revert "Refs #20972. Applying changes on CreateInputChannelResource."
    
    This reverts commit ed848e9.
    
    * Refs #20972. Add helper header with template method.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Configure methods return boolean.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Configure methods use new template method.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. OpenAndBindUnicastOutputSocket uses new template method.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Changes in OpenAndBindInputSocket.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972.Setting options on TCP channels.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Doxygen.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Check limits of configured sizes.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Add UDP unit tests.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Add TCP unit tests.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Move checks in TCP to beginning of init.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Refactor for common code in UDP.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Refactor for common code in TCP.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Remove unused constants in UDP tests.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Check final configuration on unit tests.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Uncrustify.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Less strict tests.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Remove `s_minimumSocketBuffer` from tests.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20972. Deprecate `s_minimumSocketBuffer`.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    ---------
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    (cherry picked from commit 53cd211)
    
    # Conflicts:
    #	src/cpp/rtps/transport/TCPTransportInterface.cpp
    #	src/cpp/rtps/transport/UDPTransportInterface.cpp
    #	src/cpp/rtps/transport/UDPv4Transport.cpp
    #	src/cpp/rtps/transport/UDPv6Transport.cpp
    #	test/blackbox/common/DDSBlackboxTestsListeners.cpp
    MiguelCompany authored and JesusPoderoso committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9db0859 View commit details
    Browse the repository at this point in the history
  2. Refs #21036. Fix conflicts.

    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    MiguelCompany authored and JesusPoderoso committed May 24, 2024
    Configuration menu
    Copy the full SHA
    17e3041 View commit details
    Browse the repository at this point in the history
  3. Refs #21036. Update for non-backported changes

    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    MiguelCompany authored and JesusPoderoso committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a4b4928 View commit details
    Browse the repository at this point in the history
  4. Fix on_sample_lost notification on best-effort readers for fragmented…

    … samples (#4187)
    
    * Refs #20162. Regression test.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20162. Notify sample lost when dropping fragmented change.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20167. Linters.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20162. Apply suggestions.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20162. Use constexpr for buffer size.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20162. Lower buffer size.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20351. Uncrustify.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    ---------
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    (cherry picked from commit 5ac198e)
    MiguelCompany authored and JesusPoderoso committed May 24, 2024
    Configuration menu
    Copy the full SHA
    918ba5e View commit details
    Browse the repository at this point in the history
  5. Make sample_lost_be_dw_be_dr_fragments test less flaky (#4620)

    * Refs #20692. Make sample_lost_be_dw_be_dr_fragments test less flakey.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20692. Uncrustify.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    ---------
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    MiguelCompany authored and JesusPoderoso committed May 24, 2024
    Configuration menu
    Copy the full SHA
    008ee70 View commit details
    Browse the repository at this point in the history
  6. Refs #20972. Improvements in on_sample_lost blackbox tests.

    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    MiguelCompany authored and JesusPoderoso committed May 24, 2024
    Configuration menu
    Copy the full SHA
    050be91 View commit details
    Browse the repository at this point in the history