-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20652] Fix test filtering in CMake files #4650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@richiprosima Please test this |
elianalf
approved these changes
Apr 5, 2024
@Mergifyio rebase |
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
bugfix/20652/2.10.x
branch
from
April 5, 2024 11:21
d07f5b2
to
5b9f119
Compare
@richiprosima please test this |
@Mergifyio backport 2.6.x |
✅ Backports have been created
|
@richiprosima Please test mac |
4 similar comments
@richiprosima Please test mac |
@richiprosima Please test mac |
@richiprosima Please test mac |
Description
This is a rework of #4603 for old branches where we are not using
gtest_discover_tests()
.Some commits have been directly cherry-picked, while others have been reworked.
The main difference is that here we are ignoring tests and thus the logic is positive (i.e. we
IGNORE foo bar
) while in master we are filtering them and thus the logic is negative (i.e. weTEST_FILTER -foo:bar
)@Mergifyio backport 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist