-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20542] Refactor Github CI sanitizer related jobs (backport #4662) #4676
Conversation
* Refs #20542: Add Fast DDS Sanitizer worflow with support for asan fastdds Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Add asan_discovery_server_test job Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Add tsan_fastdds_test job Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Remove colcon_meta input as max inputs for workflow_dispath is 10 Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Create a reusable workflow and a CI one for PRs or manual Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Add nightly sanitizer CI for all supported branches Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Change extension to .yml Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Remove old workflows Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Run sanitizers CI on PR review request Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Exclude xfail tests in discovery server test run Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Install all python packages needed for asan_fastdds_test reporting Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Apply Jesús' suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit ac0e737) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/config/asan_colcon.meta # .github/workflows/thread-sanitizer.yaml
Cherry-pick of ac0e737 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestions here should be applied on this PR also
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
dceedcb
to
706a7ae
Compare
As long as this PR only updates GitHub Sanitizer CI job, only corresponding CI has been run (and passed) |
Description
This PR refactors the Github CI for Address and Thread Sanitizers. It removes the old workflows and adds a single reusable one that defines 4 jobs:
asan_fastdds_build
asan_fastdds_test
(uses the build fromasan_fastdds_build
)asan_discovery_server_test
(uses the build fromasan_fastdds_build
)tsan_fastdds_test
Furthermore, it adds both a
sanitizers-ci.yaml
andnightly-sanitizers-ci.yaml
so that:no-test
andskip-ci
labels are not set.asan_fastdds_test
,asan_discovery_server_test
, andtsan_fastdds_test
. This way it is possible to run a subset of the jobs defined in the workflow.address_sanitizers.yaml
thread_sanitizer.yaml
@Mergifyio backport 2.13.x 2.10.x 2.6.x
IMPORTANT: Remove the nightly workflows from the backports, as they will not run anyways.
Contributor Checklist
Commit messages follow the project guidelines.
N/A: The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
N/A: Changes are ABI compatible.
N/A: Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4662 done by [Mergify](https://mergify.com).