Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20818] Make ResourceEvent private #4705

Merged
merged 1 commit into from
May 28, 2024
Merged

[20818] Make ResourceEvent private #4705

merged 1 commit into from
May 28, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Apr 19, 2024 •
edited by JesusPoderoso
Loading

Description

This pr makes ResourceEvent private

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Apr 19, 2024
@elianalf elianalf added needs-review PR that is ready to be reviewed needs rebase labels Apr 29, 2024
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 08ee62b to 623db82 Compare May 13, 2024 09:26
@EduPonz EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@EduPonz EduPonz reopened this May 14, 2024
@EduPonz EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:27
@elianalf elianalf force-pushed the feature/make_resource_event_private branch from 368d1ca to a8c78df Compare May 16, 2024 15:00
@JesusPoderoso JesusPoderoso self-requested a review May 20, 2024 09:16
@github-actions github-actions bot added the ci-pending PR which CI is running label May 20, 2024
JesusPoderoso
JesusPoderoso previously approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso added needs rebase and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels May 23, 2024
@elianalf elianalf force-pushed the feature/make_resource_event_private branch from a8c78df to d2d6584 Compare May 23, 2024 10:07
@JesusPoderoso JesusPoderoso self-requested a review May 23, 2024 10:16
@github-actions github-actions bot added the ci-pending PR which CI is running label May 23, 2024
JesusPoderoso
JesusPoderoso previously approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

@elianalf
Copy link
Contributor Author

@richiprosima please test_3 windows

@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label May 24, 2024
@JesusPoderoso JesusPoderoso removed the ci-pending PR which CI is running label May 24, 2024
@EduPonz EduPonz added conflicts Backport PR wich git cherry pick failed and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels May 24, 2024
@elianalf elianalf force-pushed the feature/make_resource_event_private branch from d2d6584 to fe83282 Compare May 24, 2024 07:01
@JesusPoderoso JesusPoderoso removed the conflicts Backport PR wich git cherry pick failed label May 24, 2024
@JesusPoderoso JesusPoderoso self-requested a review May 24, 2024 07:06
@github-actions github-actions bot added the ci-pending PR which CI is running label May 24, 2024
JesusPoderoso
JesusPoderoso previously approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with passed CI

@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label May 24, 2024
@EduPonz EduPonz self-requested a review May 24, 2024 07:09
EduPonz
EduPonz previously approved these changes May 24, 2024
View reviewed changes
@elianalf
Refs #20818: Make ResourceEvent private
d8089b9 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf dismissed stale reviews from EduPonz and JesusPoderoso via d8089b9 May 28, 2024 08:08
@elianalf elianalf force-pushed the feature/make_resource_event_private branch from fe83282 to d8089b9 Compare May 28, 2024 08:08
@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

@elianalf elianalf removed the no-test Skip CI tests if PR marked with this label label May 28, 2024
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 28, 2024
@EduPonz EduPonz merged commit 0d61aef into master May 28, 2024
12 checks passed
@EduPonz EduPonz deleted the feature/make_resource_event_private branch May 28, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

@EduPonz EduPonz EduPonz left review comments

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @EduPonz @JesusPoderoso