Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20862] Improve ThreadSettingsQoS logging #4744

Merged
merged 7 commits into from
May 7, 2024
Merged

[20862] Improve ThreadSettingsQoS logging #4744

merged 7 commits into from
May 7, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Apr 29, 2024 •
edited by EduPonz
Loading

Description

@Mergifyio backport 2.13.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL
Refs #20862: Add BB tests
4977c9e 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #20862: ThreadSettings logging improvements impl
8034072 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v2.14.1 milestone Apr 29, 2024
@Mario-DL
Refs #20862: Linter
e840ccd 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 29, 2024
JesusPoderoso
JesusPoderoso previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso
Copy link
Contributor

I think CI issues are unrelated to the PR
I would say it is ready to merge, unless @Mario-DL wants jenkis CI

@Mario-DL
Copy link
Member Author

Mario-DL commented May 3, 2024

@richiprosima please test this

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 6, 2024
MiguelCompany
MiguelCompany requested changes May 6, 2024
View reviewed changes
src/cpp/utils/threading.hpp Outdated Show resolved Hide resolved
src/cpp/utils/threading.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the ci-pending PR which CI is running label May 6, 2024
@JesusPoderoso JesusPoderoso removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label May 6, 2024
@Mario-DL
Refs 20862: Apply Miguel suggestions
549c96a 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL force-pushed the feature/thread-settings-logging-improvements branch from cf415d3 to 549c96a Compare May 6, 2024 14:34
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany May 6, 2024 14:34
MiguelCompany
MiguelCompany requested changes May 6, 2024
View reviewed changes
src/cpp/utils/threading/threading_empty.ipp Outdated Show resolved Hide resolved
src/cpp/utils/threading/threading_empty.ipp Outdated Show resolved Hide resolved
src/cpp/utils/threading/threading_osx.ipp Outdated Show resolved Hide resolved
src/cpp/utils/threading/threading_pthread.ipp Outdated Show resolved Hide resolved
src/cpp/utils/threading/threading_win32.ipp Outdated Show resolved Hide resolved
src/cpp/utils/threading/threading_win32.ipp Show resolved Hide resolved
@Mario-DL
Refs 20862: Apply second rev
2d6fa2f 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs 20862: Applied third round suggestions
f20cf60 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs 20862: Remove old method in threading_empty
b2c938c 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@EduPonz EduPonz removed the ci-pending PR which CI is running label May 7, 2024
@EduPonz EduPonz merged commit 7832901 into master May 7, 2024
7 of 12 checks passed
@EduPonz EduPonz deleted the feature/thread-settings-logging-improvements branch May 7, 2024 12:56
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.13.x

@mergify Mergify
Copy link
Contributor

mergify bot commented May 7, 2024 •
edited
Loading

backport 2.13.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 7, 2024
@Mario-DL @mergify
Improve ThreadSettingsQoS logging (#4744)
cd4296c 
* Refs #20862: Add BB tests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20862: ThreadSettings logging improvements impl

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20862: Linter

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Apply Miguel suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Apply second rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Applied third round suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Remove old method in threading_empty

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7832901)

# Conflicts:
#	src/cpp/utils/threading/threading_win32.ipp
@mergify mergify bot mentioned this pull request May 7, 2024
Merged
13 tasks
JesusPoderoso pushed a commit that referenced this pull request May 20, 2024
@Mario-DL @JesusPoderoso
Improve ThreadSettingsQoS logging (#4744)
44e093e 
* Refs #20862: Add BB tests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20862: ThreadSettings logging improvements impl

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20862: Linter

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Apply Miguel suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Apply second rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Applied third round suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Remove old method in threading_empty

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7832901)
EduPonz pushed a commit that referenced this pull request May 24, 2024
@mergify @Mario-DL
Improve ThreadSettingsQoS logging (#4744) (#4755)
e56f749 
* Refs #20862: Add BB tests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20862: ThreadSettings logging improvements impl

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20862: Linter

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Apply Miguel suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Apply second rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Applied third round suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs 20862: Remove old method in threading_empty

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7832901)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@JesusPoderoso JesusPoderoso JesusPoderoso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Mario-DL @JesusPoderoso @MiguelCompany @EduPonz