Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20652] Add DNS entries to hosts files on github workflows #4776

Merged
merged 4 commits into from
May 20, 2024
Merged

[20652] Add DNS entries to hosts files on github workflows #4776

merged 4 commits into from
May 20, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented May 13, 2024 •
edited by EduPonz
Loading

Description

Windows github workflow is writing the hosts file so the tests using DNS can be run.
This PR writes the /etc/hosts file using sudo tee -a on Ubuntu, Sanitizers, and Mac workflows.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.0.0 milestone May 13, 2024
@MiguelCompany MiguelCompany marked this pull request as ready for review May 13, 2024 14:24
@github-actions github-actions bot added the ci-pending PR which CI is running label May 13, 2024
@EduPonz EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@MiguelCompany MiguelCompany reopened this May 14, 2024
@MiguelCompany MiguelCompany changed the base branch from 3.0.x-devel to master May 14, 2024 07:25
@MiguelCompany
Refs #20652. Write hosts file on reusable-ubuntu-ci.
1344010 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #20652. Write hosts file on reusable-sanitizers-ci.
89a4e2d 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #20652. Write hosts file on reusable-mac-ci.
1b0dcc0 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #20652. Apply review suggestions.
6b79f9b 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@EduPonz EduPonz self-requested a review May 17, 2024 10:27
EduPonz
EduPonz approved these changes May 17, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label May 20, 2024
@EduPonz
Copy link

EduPonz commented May 20, 2024

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

@EduPonz EduPonz merged commit 625b041 into master May 20, 2024
10 of 12 checks passed
@EduPonz EduPonz deleted the hotfix/ci-dns-tests branch May 20, 2024 07:40
@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2024 •
edited
Loading

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 20, 2024
@MiguelCompany @mergify
Add DNS entries to hosts files on github workflows (#4776)
b7f6423 
* Refs #20652. Write hosts file on reusable-ubuntu-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-sanitizers-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-mac-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 625b041)
mergify bot pushed a commit that referenced this pull request May 20, 2024
@MiguelCompany @mergify
Add DNS entries to hosts files on github workflows (#4776)
a8e71b5 
* Refs #20652. Write hosts file on reusable-ubuntu-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-sanitizers-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-mac-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 625b041)
This was referenced May 20, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 20, 2024
@MiguelCompany @mergify
Add DNS entries to hosts files on github workflows (#4776)
43c204e 
* Refs #20652. Write hosts file on reusable-ubuntu-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-sanitizers-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-mac-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 625b041)
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
10 tasks
mergify bot pushed a commit that referenced this pull request May 20, 2024
@MiguelCompany @mergify
Add DNS entries to hosts files on github workflows (#4776)
6b9b44e 
* Refs #20652. Write hosts file on reusable-ubuntu-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-sanitizers-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-mac-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 625b041)
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
10 tasks
MiguelCompany added a commit that referenced this pull request May 21, 2024
@mergify @MiguelCompany
Add DNS entries to hosts files on github workflows (#4776) (#4810)
e36f6b8 
* Refs #20652. Write hosts file on reusable-ubuntu-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-sanitizers-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-mac-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 625b041)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request May 22, 2024
@mergify @MiguelCompany
Add DNS entries to hosts files on github workflows (#4776) (#4808)
93f3625 
* Refs #20652. Write hosts file on reusable-ubuntu-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-sanitizers-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-mac-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 625b041)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request May 23, 2024
@mergify @MiguelCompany
Add DNS entries to hosts files on github workflows (#4776) (#4809)
db3d420 
* Refs #20652. Write hosts file on reusable-ubuntu-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-sanitizers-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-mac-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 625b041)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Jun 5, 2024
@mergify @MiguelCompany
Add DNS entries to hosts files on github workflows (#4776) (#4811)
aca77c5 
* Refs #20652. Write hosts file on reusable-ubuntu-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-sanitizers-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-mac-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 625b041)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @EduPonz @elianalf