Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21092] Remove Windows v141 / VS 2017 build from master / 3.x CI #4853

Merged
merged 2 commits into from
May 29, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented May 27, 2024

Description

Visual Studio 2017 build is no longer supported for Fast DDS future release v3.0.0.
For that reason, this PR removes its usage in windows CI, by removing the v141 build.

To test it, this PR has the no-test label.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label May 27, 2024
@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone May 27, 2024
@JesusPoderoso JesusPoderoso self-assigned this May 27, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label May 27, 2024
@JesusPoderoso JesusPoderoso added needs-review PR that is ready to be reviewed and removed no-test Skip CI tests if PR marked with this label ci-pending PR which CI is running labels May 28, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should pass -T ${{ matrix.vs-toolset }} here as well, same as you did in #4854

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso removed the needs-review PR that is ready to be reviewed label May 28, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label May 28, 2024
@JesusPoderoso JesusPoderoso added needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels May 28, 2024
@EduPonz EduPonz merged commit d5fad1b into master May 29, 2024
4 of 11 checks passed
@EduPonz EduPonz deleted the hotfix/remove_windows_ci_v141 branch May 29, 2024 05:23
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants