Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21162] Split example tests in different ctest tests #4921

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 10, 2024

Description

Current example tests are defined under the same pytest. That makes the "all examples" test fail if the timeout (300 sec) is reached. It didn't happen before but while including new examples (and their corresponding tests) this timeout has been reached.
This PR splits the pytest file with all example tests into different pytest files under different directories, so each of them would run independently with the same timeout (300 sec).
The corresponding compose file for each test has been configured in the same directoy on build time.

Note: This has been done assuming the name matches:

  • compose file: example_name.compose.yml
  • test_example_name.py

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jun 10, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 10, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 10, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz merged commit 72642f5 into master Jun 10, 2024
10 of 11 checks passed
@EduPonz EduPonz deleted the hotfix/21162 branch June 10, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants