-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20650] Examples refactor: Delivery mechanisms #4959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusPoderoso
force-pushed
the
feature/example_refactor/delivery_mechanism
branch
from
June 18, 2024 08:39
d77ce12
to
b4a0d47
Compare
JesusPoderoso
force-pushed
the
feature/example_refactor/delivery_mechanism
branch
from
June 18, 2024 12:27
085fbd2
to
5edd104
Compare
JesusPoderoso
force-pushed
the
feature/example_refactor/delivery_mechanism
branch
from
June 19, 2024 09:54
5edd104
to
f504155
Compare
JesusPoderoso
requested review from
elianalf and
richiprosima
and removed request for
elianalf
June 19, 2024 09:58
JesusPoderoso
force-pushed
the
feature/example_refactor/delivery_mechanism
branch
from
June 19, 2024 10:40
c52f9eb
to
22cc515
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
June 19, 2024 10:40
JesusPoderoso
force-pushed
the
feature/example_refactor/delivery_mechanism
branch
from
June 19, 2024 11:04
22cc515
to
9373acb
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
June 19, 2024 11:04
JesusPoderoso
force-pushed
the
feature/example_refactor/delivery_mechanism
branch
from
June 19, 2024 11:40
9373acb
to
9df94dd
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
June 19, 2024 11:41
JesusPoderoso
force-pushed
the
feature/example_refactor/delivery_mechanism
branch
from
June 19, 2024 13:04
9df94dd
to
f1a3e24
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
June 19, 2024 13:04
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…eally stopped Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…s gen Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
feature/example_refactor/delivery_mechanism
branch
from
June 27, 2024 07:20
6d97d1f
to
60c624b
Compare
elianalf
approved these changes
Jun 27, 2024
elianalf
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.
In this delivery mechanisms example, the key changes are:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist