Prevents build of test if gtest is not found. #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
|
I'm unable to see the test results to know why it's failing. If you can provide the information I can fix it. |
|
Closed as duplicate of already merged #490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While exploring upgrading ROS2 to Fast-RTPS I had build issues with the ROS2 build farm not being able to build the the develop branch of Fast-RTPS because it did not have GTest installed (see build results on this PR: ros2/rmw_fastrtps#272). This was not an issue with previous versions of Fast-RTPS and it looks like it is just because one of the CMakeLists.txt files is missing a guard against compiling the test when GTest is not installed on the system.
This pull request fixes this by adding the build time guard in the CMakeLists.txt file.