Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21437] Builtin data related improvements #5117

Merged
merged 11 commits into from
Jul 31, 2024
Merged

[21437] Builtin data related improvements #5117

merged 11 commits into from
Jul 31, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jul 30, 2024

Description

This PR:

  • Adds topic_kind to PublicationBuiltinTopicData and SubscriptionBuiltinTopicData.
  • Removes @ingroup from the doxygen documentation of ParticipantDiscoveryStatus.
  • Makes the creation of RTPS endpoints fail when the entity id is not consistent with the topic kind specified in the corresponding attributes.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • NO: Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

MiguelCompany and others added 7 commits July 30, 2024 11:17
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.0.0 milestone Jul 30, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…oherent entity_id

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL self-requested a review July 30, 2024 14:45
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 30, 2024
Copy link
Member Author

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes by @Mario-DL look good to me.

Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 31, 2024
@MiguelCompany MiguelCompany merged commit 143dcb4 into master Jul 31, 2024
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/21437 branch July 31, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants