Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated asio lib #5188

Merged
merged 2 commits into from
Oct 4, 2024
Merged

updated asio lib #5188

merged 2 commits into from
Oct 4, 2024

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Sep 2, 2024

Description

updated asio from version 1.18.1 to 1.31.0
https://think-async.com/Asio/asio-1.30.2/doc/asio/history.html#asio.history.asio_1_30_2

Contributor Checklist

  • N/A Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NA Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NA Any new/modified methods have been properly documented using Doxygen.
  • NA Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • NA New feature has been added to the versions.md file (if applicable).
  • NA New feature has been documented/Current behavior is correctly described in the documentation.
  • NA Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • NA If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.1.0 milestone Sep 2, 2024
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mosfet80, thanks for your contribution!
CI issues are unrelated with the PR content, marking it as Ready to Merge!
LGTM

@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Oct 4, 2024
@rsanchez15 rsanchez15 merged commit a02c4cf into eProsima:master Oct 4, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants