Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21471] Convert Fast DDS v2 to v3 Migration Changes into a Step-by-Step User Guide #5281

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

LuciaEchevarria99
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented Sep 30, 2024

Description

This PR restructures the migration changes from Fast DDS v2 to v3 into a comprehensive step-by-step guide to help users in updating their projects.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

…Guide

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99 LuciaEchevarria99 added the skip-ci Automatically pass CI label Sep 30, 2024
@LuciaEchevarria99 LuciaEchevarria99 changed the title Convert Fast DDS v2 to v3 Migration Changes into a Step-by-Step User Guide [21471] Convert Fast DDS v2 to v3 Migration Changes into a Step-by-Step User Guide Sep 30, 2024
@JesusPoderoso JesusPoderoso added this to the v3.0.2 milestone Sep 30, 2024
JesusPoderoso

This comment was marked as resolved.

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed skip-ci Automatically pass CI labels Sep 30, 2024
@rsanchez15 rsanchez15 merged commit 20a4c10 into master Sep 30, 2024
3 checks passed
@rsanchez15 rsanchez15 deleted the migration-guide branch September 30, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants