Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21802] Fix CreateTopicWithDifferentTypeName_negative flaky test #5307

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Oct 4, 2024

Description

CreateTopicWithDifferentTypeName_negative is failing on Mac due to a std::system_error exception launched by SharedMemory transport when the test is closing. The problem is the created participant is not deleted accordantly.

@Mergifyio backport 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Fix CreateTopicWithDifferentTypeName_negative flaky test [21802] Fix CreateTopicWithDifferentTypeName_negative flaky test Oct 4, 2024
@MiguelCompany MiguelCompany added this to the v3.1.0 - Frozen ❄️ milestone Oct 4, 2024
@MiguelCompany MiguelCompany self-requested a review October 4, 2024 11:14
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 4, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@richiware richiware merged commit c92b561 into master Oct 7, 2024
17 checks passed
@richiware richiware deleted the bugfix/21801 branch October 7, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants