Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20893] Switch master to 4.0.x #142

Merged
merged 4 commits into from
May 14, 2024
Merged

[20893] Switch master to 4.0.x #142

merged 4 commits into from
May 14, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented May 14, 2024 •
edited by elianalf
Loading

Description

This PR makes master branch become 4.0.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented.
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

JLBuenoLopez and others added 4 commits May 14, 2024 11:01
@JLBuenoLopez @richiware @adriancampo
XTypes v1.3 refactor (#130)
53c6cce 
* Several changes to support fastddsgen -genapi [19957] (#105)

* Refs #19944. Context uses TemplateManager

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19944. Fix setting scope

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Fix union discriminator (#106)

* Refs #19932: fix union discriminator

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19932: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refactor Member and ContainerTypeCode to use common applied annotations API (#107)

* Refs #19968: refactor Member and ContainerTypeCode to use common applied member annotations API

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19968: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Remove calling with option -cdr (#109)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Support to have configuration by STGroup (#108)

* Refs #19960. Support to have config by STGroup

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19960. Fix conding style.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19960. Apply suggestions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Changeable max size for unbounded containers (#111)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Support for C++ enum class (#112)

* Refs #20063. Support C++ enum class

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20063. Fix bitmasks

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20063. Accessing through Context

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Fix missing function (#113)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Improve in code (#114)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Fix after rebase

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* New API and fixes for TypeObject generation (#119)

* Changes to run typeobject tests  (#103)

* Refs #19115: include method to check if type is boolean

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: accesors to primitive types and enum types

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: add scoped name to annotation declarations

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: add API to check verbatim annotation. Sanity check to ensure that given enumeration value is valid

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: remove quotes from annotation value

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: discriminate builtin annotations

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: API for max and min annotation values (@range)

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: expose scoped name in Annotation API

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: include XTypes v1.3 builtin annotations and fix IDL v4.2 builtin annotations

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: throw exception if annotation is not previously defined

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: remove isIsEnumType defined twice (after rebase)

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: try_construct implementation

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: type system only supports single inheritance

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19115: check autoid annotation API

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Added TypeObject tests flag.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* change run() method to work with different types of tests.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Refs #19595: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: revert changes: -typeobject option will be used to generate legacy TypeObject code

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: check autoid annotation API

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: try_construct annotation implementation

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: add API to check @id and @hashid builtin annotations

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: API to get number of members

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: add getBitBound API to enum types

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: add API to get number of annotation parameters

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix merge conflicts

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: add API to check if an annotation is builtin

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: add API to check number of applicable labels

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix merge conflicts

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: refactor array_type

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: add array API to check bound sequence size

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix after rebase

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: remove non-necessary template attribute

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: include API to get number of annotation parameters

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: apply review suggestion: use new scopedname strategy

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: apply review suggestion

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Fix API for TypeObject code generation (#110)

* Refs #19595: code style

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: return annotation default value

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: add Alias API for container types aliased

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix typos in primitive API

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: explictly override

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: fix TypeCode::isAnnotationAutoidHash function

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: return correct TypeIdentifier kind

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: return correct type identifier

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: unbounded collections use small TypeIdentifier

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: fixes after rebase

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: return correct TypeIdentifier for arrays

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: return correct TypeIdentifier for maps

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: non applied extensibility and try_construct annotations

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: get main project API (generate TypeObject tests only for the main project)

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix Annotation Autoid hash return value

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: add getFirstMember API

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix bitset holder type

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix collection TypeIdentifier

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: recursive types fail generating TypeObject

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: API to check if contained members are forwarded

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix bitset bitfields

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: use variables instead of hardcoded strings

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fixes after rebase

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Co-authored-by: Adrian del Campo <107918259+adriancampo@users.noreply.github.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Hotfix: extend AliasTypeCode API: getCScopedname (#120)

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Document isIsBounded and isUnbound API. Correctly use the API (#121)

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Fixes after rebase

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Fix find and set default value for unions [20587] (#124)

* Refs #19451. Fix find and set default value for unions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451. Remove unused functions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451. Rollback default discriminator

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451. Apply suggestions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Apply suggestions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Apply suggestions 2

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
Co-authored-by: Adrian del Campo <107918259+adriancampo@users.noreply.github.com>
@richiware
Refs #20973. New STG API function to check if a union needs the defau…
7b3ca08 
…lt case (#138)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
New STG API functions to check the type of TypeIdentifier [21005] (#140)
4cd4098 
* Refs #20424. New STG API functions to check the type of TypeIdentifier

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20424. Apply suggestion

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@EduPonz
Prepare 4.0.x-devel to become master (#141)
18513d0 
* Refs #20893: Add mirror workflow

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20893: Add PR template

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20893: Add more branches to the backport list

Signed-off-by: eduponz <eduardoponz@eprosima.com>

---------

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v4.0.0 milestone May 14, 2024
@EduPonz EduPonz merged commit 26f8c41 into master May 14, 2024
2 checks passed
@EduPonz EduPonz deleted the 4.0.x-devel branch May 14, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf elianalf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@EduPonz @elianalf @JLBuenoLopez @richiware