Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21430] Add check not using @key in derived structures #154

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 29, 2024

Description

This PR applies a suggestion: check @key annotation is not used in a structure's member of a derived structure.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented.
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Add check not using @key in derived structures [21430] Add check not using @key in derived structures Jul 29, 2024
@richiware richiware added this to the v4.0.0 milestone Jul 29, 2024
@richiware richiware merged commit 0e8ce7e into master Jul 29, 2024
2 checks passed
@richiware richiware deleted the feature/21385 branch July 29, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants