New idl for testing setting the MemberId [20109] #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
JLBuenoLopez
suggested changes
Dec 11, 2023
IDL/member_id.idl
Outdated
Comment on lines
4
to
5
| @id(100) | ||
| octet o; |
There was a problem hiding this comment.
Personally, I think it is easier to read if the annotation and the type are in the same line as it is usually written in the specifications. Otherwise, it might be helpful to include a blank line between types. Though this is only a style suggestion and as there is no IDL code style, it can be overlooked.
IDL/member_id.idl
Outdated
Comment on lines
117
to
128
| @autoid(HASH) | ||
| struct DerivedAutoidHash : AutoidHash | ||
| { | ||
| char cd; | ||
| @id(101) | ||
| octet od; | ||
| @hashid | ||
| short sd; | ||
| @hashid("long2") | ||
| long ld; | ||
| long long lld; | ||
| }; |
There was a problem hiding this comment.
There is a specific inheritance test case that it would be nice to test as well. What happens if there is nested inheritance as the following IDL:
struct SomeStruct
{
short some_var;
};
struct EmptyStruct : SomeStruct
{
};
struct AnotherInheritedStruct : EmptyStruct
{
long another_var;
};
Probably the logic in IDL Parser would handle this case correctly, but I suggest having the test case to ensure that in the future is not broken.
richiware
changed the title
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.