Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git apply instead of cherry-pick #42

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Use git apply instead of cherry-pick #42

merged 1 commit into from
Oct 23, 2020

Conversation

MiguelCompany
Copy link
Member

Follow-up of #41

As git cherry-pick creates a commit, it requires git user configuration to be set.

This PR changes this for getting the diff of the commit with curl and using git apply with the downloaded diff.

Signed-off-by: Miguel Company MiguelCompany@eprosima.com

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 0e6174a into master Oct 23, 2020
@MiguelCompany MiguelCompany deleted the bugfix/9713 branch October 23, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants