[11561] Upgrade installer to support cmake linking statically or dynamically to Fast-DDS #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiware
requested changes
May 17, 2021
foonathan_memory-config.cmake
Outdated
| endif() | ||
| elseif(MSVC_VERSION GREATER_EQUAL 1920) | ||
| if(MSVC_VERSION LESS_EQUAL 1900) | ||
| message(FATAL_ERROR "Not supported version of Visual Studio") |
There was a problem hiding this comment.
Suggested change
| message(FATAL_ERROR "Not supported version of Visual Studio") | |
| message(FATAL_ERROR "Not supported version ${MSVC_VERSION} of Visual Studio") |
added 2 commits
May 17, 2021 16:20
… binary deployment Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
MiguelBarro
force-pushed
the
feature/installer_cmake_static
branch
from
0e8892b to
6f27ea6
Compare
richiware
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using
cmake -DFASTDDS_STATIC=ON... is possible to link statically to a Fast-DDS installation (formerly only dynamic linking was available).