[20596] Feature: topic keys with non breaking ABI (humble backport) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #20164: rmw_fastrtps_shared: prepare api for keys support Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_shared: getKey() implementation Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps* interface methods update for keys support Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_cpp empty implementation Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_dynamic_cpp Message & Service Typesupport construction updates Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_dynamic_cpp type_support_proxy updates implementation Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_dynamic_cpp type_support implementation Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: Move typesupport key vars to rmw_fastrtps_shared_cpp Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: Initialize Typesupport key members in rmw_fastrtps_cpp Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_shared_cpp: add abi_version enum and type support member Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_cpp: adopt abi version v2 Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_dynamic_cpp: adopt abi version v2 Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_shared_cpp: apply_qos_resource_limits_for_keys() free function Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_cpp: apply qos for keys Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_dynamic_cpp: apply qos for keys Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: fix: include checking for the v2 identifier when trying to register the typesupport_introspection. This is useful when builtin types are also built with v2 abi and rmw_fastrtps_cpp is used Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_cpp review 2 suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Updates according latest message_type_support structure (no initial alignment) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Compile for Fast CDR 1 only Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Comment typo Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…humble Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Yes. This is because of the |
MiguelCompany
approved these changes
Mar 8, 2024
Mario-DL
added a commit
that referenced
this pull request
Jun 21, 2024
* Refs #20596: Cherry pick Keys Feature from iron * Refs #20164: rmw_fastrtps_shared: prepare api for keys support Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_shared: getKey() implementation Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps* interface methods update for keys support Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_cpp empty implementation Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_dynamic_cpp Message & Service Typesupport construction updates Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_dynamic_cpp type_support_proxy updates implementation Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: rmw_fastrtps_dynamic_cpp type_support implementation Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: Move typesupport key vars to rmw_fastrtps_shared_cpp Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20164: Initialize Typesupport key members in rmw_fastrtps_cpp Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_shared_cpp: add abi_version enum and type support member Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_cpp: adopt abi version v2 Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_dynamic_cpp: adopt abi version v2 Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_shared_cpp: apply_qos_resource_limits_for_keys() free function Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_cpp: apply qos for keys Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_dynamic_cpp: apply qos for keys Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: fix: include checking for the v2 identifier when trying to register the typesupport_introspection. This is useful when builtin types are also built with v2 abi and rmw_fastrtps_cpp is used Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: rmw_fastrtps_cpp review 2 suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Updates according latest message_type_support structure (no initial alignment) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Compile for Fast CDR 1 only Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Comment typo Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20596: Adapt rmw_fastrtps_shared_cpp: adapt getKey() method to humble Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the work from #22 into
vulcanexus-humble.It gave two little conflicts that were addressed with no further problems
rmw_fastrtps_cpp/subscription.cpp:rmw_fastrtps_dynamic_cpp/subscription.cpp:In addition, I include another commit fixing the
getKey()method inrmw_fastrtps_shared_cppsince theSerializedDatastructseems to have a different structure inhumble. But nothing remarkable.Important
If we port to ROS 2
humbleat any time, this PR relies onFast DDS v2.6.8because it needs eProsima/Fast-DDS#4308 and eProsima/Fast-DDS#4353