Introduce on_exception handler. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuiu
approved these changes
Dec 4, 2021
There was a problem hiding this comment.
Hi @warownia1 ,
thanks for you Pull Request, and sorry for late reply/review, for some reasons I wasn't subscribed to be notified of new PRs on this repo, but fixed now. It's very useful, I also felt the need of such a callback handler a couple of times, but every time was over busy on other things to implement it.
Thanks for it, great code/documentation, and nice that it's also tested.
I'm merging it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New on_exception parameter takes a function which is called whenever an exception is captured. It allows to perform extra actions on error as well as interrupt further retries dynamically.