Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove journal entries when kanka enteties are removed #47

Closed
jonepatr opened this issue Jun 11, 2021 · 2 comments
Closed

Remove journal entries when kanka enteties are removed #47

jonepatr opened this issue Jun 11, 2021 · 2 comments
Labels
enhancement New feature or request released

Comments

@jonepatr
Copy link

Following these steps,

  • adding an entity (e.g. character) in kanka
  • linking it in foundry
  • removing it in kanka

Pressing "update outdated" or anything else does not remove that entity. Seems like only manual removal is possible
@eXaminator
Copy link
Owner

That is true. I treat the data from Kanka as the source of truth and don't check if anything is missing that was improted previously.

I feel like this shouldn't be completely automatic though, but maybe a separate list in the browser that shows you all the deleted entities with a button to remove them all at once. Though I'll have to keep in mind that I also have to check that they match the current campaign, otherwise it would show you entities from other campaigns as deleted (because they aren't in the list of entities for the current campaign).

I'll look into this and see if I can find a good solution. Thanks for the idea!

@eXaminator eXaminator added the enhancement New feature or request label Jun 11, 2021
eXaminator added a commit that referenced this issue Jun 19, 2021
@eXaminator
feat: add list of entities that have been deleted in kanka but exist …
4d39b42 
…in foundry

Fixes #47
github-actions bot pushed a commit that referenced this issue Jun 26, 2021
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
c01a42f 
# [2.2.0](2.1.1...2.2.0) (2021-06-26)

### Features

* add list of entities that have been deleted in kanka but exist in foundry ([6018241](6018241)), closes [#47](#47)
* add official 0.8.8 support ([d6160cd](d6160cd))
* hide entities that are marked as template by default ([7c99f52](7c99f52))
* improve asset gallery view ([8b86f8b](8b86f8b))
* move all notes to the first tab to mirror Kankas new behavior ([48a9203](48a9203))
* rename tabs to fall in line with recent Kanka update ([9a20ebe](9a20ebe))
@github-actions
Copy link

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonepatr @eXaminator