add tests to arrowop spec for #1960

[line-o]

Description:

adds 4 tests to the arrowop test suite

• ao:wrap-atomic-sequence
• ao:wrap-atomic-sequence-with-explicit-type-conversion
• ao:wrap-element-sequence (pending)
• ao:wrap-attribute-from-sequence (pending)

Reference:

They were added to test #1960

Type of tests:

xqsuite

[dizzzz]

build fails

[adamretter]

Requires #2140 first

[joewiz]

Now that #2140 is merged in, I assume all that is needed is rerunning the CI checks to see. Can anyone with permissions to Travis and AppVeyor rerun the CI checks?

[joewiz]

Sorry, upon closer inspection I see #2140 is not actually merged. But I thought we decided to merge it in even though there were some outstanding issues?

[dizzzz]

@joewiz I thought that we indeed decided that.... merge despite of....

[adamretter]

@dizzzz @joewiz No we did not decide to merge #2140. We decided to merge other PRs which contained bugfixes that help towards #2140. Which I did, just before the previous release window.

[joewiz]

@adamretter FYI we discussed this further in yesterday’s call. The plan is for @wolfgangmm and @dizzzz to (1) mark remaining failing tests as pending, (2) create issues out of each individual failure, and (3) merge this (and its ports) so that the PRs that rely on it can be merged.

[adamretter]

@joewiz I really think that is a bad idea. Whenever tests are marked as pending/ignored there is a tendency for them never to be fixed. We could have just done that originally but decided not to for exactly that reason. I really don't want to see #2140 merged before the problems are really fixed.

[adamretter]

@line-o #2140 is now merged. Could please rebase this on the develop HEAD? We can then look to get this PR merged.

[line-o]

This PR is not longer necessary due to #2447