Skip to content

Commit

Permalink
Do not fix buildFingerprint() method
Browse files Browse the repository at this point in the history
  • Loading branch information
pgrenaud committed Feb 10, 2021
1 parent c72ce7a commit d535516
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion src/ConfigEnvironment.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,16 @@ public function getReleasePath($release, $path = '')
*/
public function buildFingerprint()
{
return sha1($this->get('server') . $this->get('deploy_path'));
// This method should have computed an hash combining the server
// string and the deploy path (see the line bellow), but I forgot to
// fix this method when splitting 'server' into 'ssh_user' and
// 'ssh_host'. Since fixing this would cause issue with all existing
// cronjobs and not fixing this does not, I'm leaving this comment
// as an explanation why I did not fix it and left it as-is.
//
// return sha1($this->get('ssh_user') . '@' . $this->get('ssh_host') . ':' . $this->get('deploy_path'));

return sha1($this->get('deploy_path'));
}

/**
Expand Down

0 comments on commit d535516

Please sign in to comment.