Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary support for ghc-modi #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

int3
Copy link

@int3 int3 commented Jul 24, 2014

This enables the check and info functions to use ghc-modi if it is available. This addresses part of #48.

I had sketched an implementation for make as well, but it fails a lot of ghcmod-vim's tests due to DanielG/ghc-mod#275, so it's been left out for now.

Also, ghc-modi does not support spaces in filenames (DanielG/ghc-mod#295), so check and info inherit this issue.

The g:ghcmod_should_use_ghc_modi flag determines whether the plugin attempts to use ghc-modi.

int3 added 4 commits July 24, 2014 23:42
Right now only the 'type' and 'info' functions are supported. ghc-modi's
`make` is still somewhat buggy.
@darthdeus
Copy link

@RubenAstudillo
Copy link

I'm using this, I really like it.

@ibotty
Copy link

ibotty commented Oct 6, 2014

is anything holding it back?

@denibertovic
Copy link

What's the status on this?

@gilligan
Copy link
Contributor

gilligan commented Dec 2, 2014

@eagletmt can you merge this ? it seems to be working just fine and is a massive improvement in usability.

@rgrinberg
Copy link

+1

@denibertovic
Copy link

FYI, both issues mentioned by the @int3 in his first comment have been solved.

@ches
Copy link

ches commented Feb 16, 2015

It would be nice if :GhcModKillModi were mentioned in the doc file, and probably some general note about how the ghc-modi support works so that users have some troubleshooting hint to identify when an misbehaving process is to blame for things not working.

But otherwise 👍

@parsonsmatt
Copy link

I've been using this fork myself and it's a massive improvement. Anything we can do to bring it into master?

@liskin liskin mentioned this pull request Oct 7, 2016
@liskin
Copy link

liskin commented Oct 7, 2016

I rebased this on top of current master and changed a few things. Most notably I unified handling of newlines/boundary and added support for multiple ghc-modi instances (one per package). It works for me with a rather large multipackage haskell codebase that uses stack.

See #102 for my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants