Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Remove inferred cabal include paths #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

corngood
Copy link

If you've build a cabal project against multiple sandboxes, you'll end up with all of their cabal_macros.h headers included with -optP, which leads to errors like:

In file included from <command-line>:8:0: 

[..]/dist/dist-sandbox-4f8d9efc/build/autogen/cabal_macros.h:11:0:
     error: "VERSION_OpenGL" redefined [-Werror]
     #define VERSION_OpenGL "2.12.0.1"
     ^

I believe it's all handled correctly in ghc-mod now with cabal-helper, and I haven't had any problems after removing the include paths.

I haven't extensively tested this, tracked down the ghc-mod version requirement (I'm using HEAD), or updated tests, so [wip].

Any thoughts?

@DanielG
Copy link

DanielG commented Sep 11, 2015

How on earth can you even build agains multiple sandboxes O_o? Can you link me to some docs? But it's nice that we're handling that correctly (by accident) I guess :)

@corngood
Copy link
Author

Not multiple sandboxes in a single build, but having multiple dist-sandbox directories because at some point it's been built to different sandboxes. This can happen after changing cabal or ghc versions without cleaning. I imagine it can also happen if you use add-source from multiple sandboxes.

On Sep 11, 2015, at 03:00, Daniel Gröber notifications@github.com wrote:

How on earth can you even build agains multiple sandboxes O_o? Can you link me to some docs? But it's nice that we're handling that correctly (by accident) I guess :)


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants